Increase timeout for dualstack test to 240 minutes 1.68.x backport #39289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport of grpc#38894 to 1.68.x.
|
Was that commit actually cherry-picked or did you just manually make the change? |
|
Manually made the change.
…On Thu, Apr 17, 2025, 7:39 PM Yash Tibrewal ***@***.***> wrote:
Was that commit actually cherry-picked or did you just manually make the
change?
—
Reply to this email directly, view it on GitHub
<#39289 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHB2YHC6PA72H6ZO4BBULFD2Z6Y3BAVCNFSM6AAAAAB3KVQQK6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJTGA3DCMRVGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
*yashykt* left a comment (grpc/grpc#39289)
<#39289 (comment)>
Was that commit actually cherry-picked or did you just manually make the
change?
—
Reply to this email directly, view it on GitHub
<#39289 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHB2YHC6PA72H6ZO4BBULFD2Z6Y3BAVCNFSM6AAAAAB3KVQQK6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJTGA3DCMRVGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
You should not be doing this manually. You should be cherry-picking the commit from the master branch. That helps preserve history, and makes things easier for comparing branches as well. |
yashykt
requested changes
Apr 18, 2025
|
I will cherrypick the master branch commit instead of manually backporting the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #38894 to 1.68.x.