#539 The deprecated function get_all_user_name fields should be replaced if possible #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…placed if possible
|
This patch looks like it should work cleanly (including being backwards compatible with earlier Moodle versions), would there be any chance it could be integrated + the updated plugin published? Noting that in Moodle 4.5, the old function no longer exists, so this becomes a fatal error, not just a warning. |
|
Yeah, we're seeing server 500 errors, so it would be great to have this reviewed and merged. |
Contributor
|
@jrchamp Unfortunately, H5P Group seldomly communicates on github. You may have better chances reaching out to them via the forums on h5p.org. |
|
Unfortunately still not applied after half a year... |
|
This issue has shown on a Moodle 4.5 upgrade. Patch works a charm so hoping this can be approved and integrated into the plugin soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
\core_user\fieldsAPI should be applied if possible.