Add a libh2o-evloop target #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you for the PR. Since the libuv-version and the embedded-version of libh2o is not source-compatible, I think it is inappropriate to determine the build mode automatically. I would appreciate it if you could adjust CMakeLists.txt to build two versions of the library under different names (i.e. build |
Contributor
Author
|
Right, I now see what you meant in #173 (comment). Is this better? I'm not really familiar with CMake and I'm not sure whether you prefer |
Member
|
Thank you for the fix! All looks fine. Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preferred usage of
libh2ois with thelibuvevent loop. If the latter is not available, building libh2o will fail.A user might however want to avoid that dependency and it doesn't cost us much to allow that.