Fix proxy_idle_time to exclude client latency #3358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change measures proxy_idle_time as the time from when we create the backend client until we receive the first byte from the backend. Prior to this patch we measured the time from when we received the first byte from the client until we received the first byte from the backend which inadvertently included network and client latency resulting in inflated proxy_idle_times.
Member
|
@jcbran thank you for the PR, there seems to be an issue with the tests, would you mind taking a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change measures proxy_idle_time as the time from when we create the backend client until we receive the first byte from the backend.
Prior to this patch we measured the time from when we received the first byte from the client until we received the first byte from the backend which inadvertently included network and client latency resulting in inflated proxy_idle_times.