-
Notifications
You must be signed in to change notification settings - Fork 878
[h2o_mruby] Add H2O class and simple method #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for the PR. The code looks good to me. OTOH How about adding other features and then merging to master? EDIT. FYI we use clang-format for indenting the source files. Applying |
|
Thank you for your review.
I wanted to implement a simple method of
Thank you for the notice. I see! |
b16c9b1 to
a6106f0
Compare
|
@kazuho sorry for my late response. I implemented error log method and applied clang-format, but I'm not sure what to do about test of error log method. What do you think about this test? |
|
@matsumoto-r Thank you for the updates. The code looks good to me.
I would not request every method to have a test. In this case, I think we can go without having one. |
|
@kazuho Thank you for your thoght. So, I had just finished the scope of this PR which include |
[h2o_mruby] Add H2O class and simple method
|
Sorry for being late. LGTM. Merged to master. |
|
Thanks!! |
h2o_mruby support H2O class of mruby. For now, I implemented
H2O.max_headersmethod.