Skip to content

Conversation

@jangrewe
Copy link
Contributor

The blacklist was read asynchronously and didn't really stop any blacklisted user from sending commands - now it does.
The Dockerfile creates an Alpine based container that includes the config and blacklist at build time.

ToDo: environment variables to configure the Docker containers

Fix Blacklist
@coveralls
Copy link

Coverage Status

Coverage decreased (-5.9%) to 5.117% when pulling 064ff43 on jangrewe:master into 2c44c00 on htilly:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-5.9%) to 5.117% when pulling 064ff43 on jangrewe:master into 2c44c00 on htilly:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.9%) to 5.096% when pulling 15c8547 on jangrewe:master into 2c44c00 on htilly:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.5%) to 5.508% when pulling 84b0777 on jangrewe:master into 2c44c00 on htilly:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-5.5%) to 5.508% when pulling 84b0777 on jangrewe:master into 2c44c00 on htilly:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.04%) to 12.076% when pulling 7671b0d on jangrewe:master into 2c44c00 on htilly:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+1.04%) to 12.076% when pulling 7671b0d on jangrewe:master into 2c44c00 on htilly:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 11.966% when pulling a0ab117 on jangrewe:master into 2c44c00 on htilly:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 11.966% when pulling a0ab117 on jangrewe:master into 2c44c00 on htilly:master.

@coveralls
Copy link

coveralls commented Dec 1, 2016

Coverage Status

Coverage increased (+0.5%) to 11.562% when pulling cc05d1e on jangrewe:master into 2c44c00 on htilly:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 11.515% when pulling dc75927 on jangrewe:master into 2c44c00 on htilly:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 11.515% when pulling dc75927 on jangrewe:master into 2c44c00 on htilly:master.

@coveralls
Copy link

coveralls commented Dec 1, 2016

Coverage Status

Coverage increased (+0.4%) to 11.446% when pulling 8e06576 on jangrewe:master into 2c44c00 on htilly:master.

@htilly htilly merged commit c5fa868 into htilly:master Dec 1, 2016
@htilly
Copy link
Owner

htilly commented Dec 1, 2016

Awesome!

@jangrewe
Copy link
Contributor Author

jangrewe commented Dec 1, 2016

Please be aware that there were a couple more changes besides the ones mentioned in the initial commit, especially how the blacklist is configured now and how configuration options can be set - this shouldn't break anything for existing users, but some people may be surprised that their blacklist.txt doesn't work anymore ;-)

@htilly
Copy link
Owner

htilly commented Dec 1, 2016

Roger!
Oho, if you do have some time to spend, please have a look at _gongPlay :-D

/Tilly

@jangrewe
Copy link
Contributor Author

jangrewe commented Dec 2, 2016

I will! We're "launching" it in our office today, so i'll probably hold off for a couple of days, but expect more PRs from me in the future ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants