Skip to content

Remove hardcoded cuda from fsdpv2#3631

Merged
S1ro1 merged 1 commit into
mainfrom
remove-cuda-from-fsdp2
Jun 17, 2025
Merged

Remove hardcoded cuda from fsdpv2#3631
S1ro1 merged 1 commit into
mainfrom
remove-cuda-from-fsdp2

Conversation

@IlyasMoutawwakil

@IlyasMoutawwakil IlyasMoutawwakil commented Jun 17, 2025

Copy link
Copy Markdown
Member

What does this PR do?

device_type is accessible from device mesh

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@IlyasMoutawwakil IlyasMoutawwakil requested a review from S1ro1 June 17, 2025 12:01
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@S1ro1 S1ro1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, LGTM!

@S1ro1 S1ro1 merged commit 8878d93 into main Jun 17, 2025
28 of 29 checks passed
@S1ro1 S1ro1 deleted the remove-cuda-from-fsdp2 branch June 17, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants