Skip to content

Conversation

@dvsrepo
Copy link
Member

@dvsrepo dvsrepo commented Feb 12, 2025

This PR enhances the prompt for column generation from scratch and from data.

The most important change is that we now include the inputs and outputs in the examples (human demonstrations) section.

Note: We're not using the system message but the user message. This is to make the approach as general as possible, as some models don't support system messages.

@dvsrepo dvsrepo requested a review from frascuchon February 12, 2025 13:31
@frascuchon
Copy link
Collaborator

Nice! Can you mark with a TODO all the code related to non-streaming execution? To remove it in the future

@dvsrepo
Copy link
Member Author

dvsrepo commented Feb 13, 2025

Nice! Can you mark with a TODO all the code related to non-streaming execution? To remove it in the future

Some changes were unintended it's good to leave it for now as we do more testing.

I've addressed your other comment and recovered the examples functionality for runPromptFromScratch that I had missed when refactoring

@frascuchon frascuchon self-requested a review February 13, 2025 09:04
@frascuchon frascuchon merged commit 7c69851 into main Feb 13, 2025
1 check passed
@frascuchon frascuchon deleted the chore/improve-system-prompts branch February 13, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants