Skip to content

Fix #352: FSDP2 argument typo #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
a-r-r-o-w merged 1 commit into from
Apr 12, 2025
Merged

Fix #352: FSDP2 argument typo #370

a-r-r-o-w merged 1 commit into from
Apr 12, 2025

Conversation

@a-r-r-o-w
Copy link
Contributor

@a-r-r-o-w a-r-r-o-w commented Apr 12, 2025

Fixes #352.

The mistake was probably made last minute due to some undo's during the major refactor for accelerate compatibility - #339 - because the test suite ran to completion.

@a-r-r-o-w a-r-r-o-w merged commit 15c490e into main Apr 12, 2025
1 check passed
@a-r-r-o-w a-r-r-o-w deleted the fix/fsdp2 branch April 12, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 gpus train hunyuan: PytorchDTensorParallelBackend.apply_fsdp2() got an unexpected keyword argument 'dp_mesh'

2 participants

@a-r-r-o-w