Skip to content

add __init__.py to sft_trainer/ to fix #335 #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
a-r-r-o-w merged 1 commit into from
Mar 18, 2025
Merged

add __init__.py to sft_trainer/ to fix #335 #336

a-r-r-o-w merged 1 commit into from
Mar 18, 2025

Conversation

@jbilcke-hf
Copy link
Contributor

@jbilcke-hf jbilcke-hf commented Mar 18, 2025 •
edited
Loading

This is a fix for #335

In order for the content of /finetrainers/trainer/sft_trainer/ to be copied during pip install, I believe it is necessary to put a __init__.py inside the directory

a-r-r-o-w
a-r-r-o-w approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jbilcke-hf! Was able to reproduce and didn't know this happens 🤯

@a-r-r-o-w a-r-r-o-w merged commit 54c29c6 into huggingface:main Mar 18, 2025
1 check passed
@jbilcke-hf
Copy link
Contributor Author

jbilcke-hf commented Mar 18, 2025

@a-r-r-o-w me neither! Python is full of surprises 😄

@jbilcke-hf jbilcke-hf deleted the fix_missing_sft_trainer_files branch March 18, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@a-r-r-o-w a-r-r-o-w a-r-r-o-w approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbilcke-hf @a-r-r-o-w