feat: add type hint to get_peft_model
#566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
Author
|
@pacman100 I noticed they are several places where it could be useful to have more type hint. Would you be interested as well in a bigger PR ? |
Guy-Bilitski
pushed a commit
to Guy-Bilitski/peft
that referenced
this pull request
May 13, 2025
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
cyyever
pushed a commit
to cyyever/peft
that referenced
this pull request
Sep 4, 2025
* correct glitches in reward modelling * add the eval_split option * correct code format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This small PR add a return type hint on
get_peft_model.This makes it easier for IDE (in my case pycharm) to propose shortcuts and suggestions if it knows the type of return objet.
For instance without the type hint in pycharm I cannot click on
save_pretrainedof peft a model and see the signature. This is because pycharm don't know that the object is a peft model. Return type hint fixed this