Skip to content

revert change #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pacman100 merged 1 commit into from
Jul 19, 2023
Merged

revert change #731

pacman100 merged 1 commit into from
Jul 19, 2023

Conversation

@pacman100
Copy link
Contributor

@pacman100 pacman100 commented Jul 19, 2023

What does this PR do?

  1. Reverts the change from a WIP thing that got merged in main

younesbelkada
younesbelkada approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THanks !

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 19, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

BenjaminBossan
BenjaminBossan approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pacman100 pacman100 merged commit 1c27e24 into main Jul 19, 2023
@younesbelkada younesbelkada deleted the smangrul/revert branch July 19, 2023 09:02
Guy-Bilitski pushed a commit to Guy-Bilitski/peft that referenced this pull request May 13, 2025
@pacman100
revert change (huggingface#731)
6a8217e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenjaminBossan BenjaminBossan BenjaminBossan approved these changes

+1 more reviewer

@younesbelkada younesbelkada younesbelkada approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pacman100 @HuggingFaceDocBuilderDev @BenjaminBossan @younesbelkada