FIX Don't assume model_config contains the key model_type #1012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
younesbelkada
approved these changes
Oct 10, 2023
Contributor
younesbelkada
left a comment
There was a problem hiding this comment.
Makes sense, thanks @BenjaminBossan !
Guy-Bilitski
pushed a commit
to Guy-Bilitski/peft
that referenced
this pull request
May 13, 2025
cyyever
pushed a commit
to cyyever/peft
that referenced
this pull request
Sep 4, 2025
* Update utils.py update compute_accuracy to deal with the cases where str_chosen and str_rej got the same scores, which is probably what the developers don't want * Update utils.py updated so only warning is reserved * Update trl/trainer/utils.py Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com> --------- Co-authored-by: Leandro von Werra <lvwerra@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #1011