Update the release checklist #1075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed, we wanted to make small amendments to the release process, so that we have a 0.N.0 commit on main. I also adjusted the wording here and there. There were some open questions, which I have marked with a FIXME. Please let me know how to proceed with those.
|
The documentation is not available anymore as the PR was closed or merged. |
pacman100
reviewed
Nov 6, 2023
Contributor
pacman100
left a comment
There was a problem hiding this comment.
Thank you @BenjaminBossan for updating the release checklist! Have replied to the FIXME parts. Good to merge once those are addressed
setup.py
Outdated
| # Push the tag to git: | ||
| # git push --tags origin main | ||
| # It is necessary to work on the original repository, not on a fork. | ||
| # FIXME should we create an annotated tag: git tag -a ... |
Contributor
There was a problem hiding this comment.
Yes, let's use annotated tag as it is more informative and better for public releases
setup.py
Outdated
| # git push --tags origin main | ||
| # It is necessary to work on the original repository, not on a fork. | ||
| # FIXME should we create an annotated tag: git tag -a ... | ||
| # FIXME we can also skip this and let GH release create the tag for us |
Contributor
There was a problem hiding this comment.
Let's explicitly have the tag step before release.
setup.py
Outdated
| # twine upload dist/* -r pypitest | ||
| # twine upload dist/* -r pypitest --repository-url=https://test.pypi.org/legacy/ | ||
| # 6. Check that you can install it in a virtualenv by running: | ||
| # FIXME are both commands needed? I think not |
Contributor
There was a problem hiding this comment.
Yes, I think the second one isn't required
Member
Author
|
@pacman100 I updated the PR according to your comments, please check again. |
Guy-Bilitski
pushed a commit
to Guy-Bilitski/peft
that referenced
this pull request
May 13, 2025
As discussed, we wanted to make small amendments to the release process, so that we have a 0.N.0 commit on main. I also adjusted the wording here and there.
cyyever
pushed a commit
to cyyever/peft
that referenced
this pull request
Sep 4, 2025
* add KTO loss * fix docs * Update trl/trainer/dpo_trainer.py Co-authored-by: lewtun <lewis.c.tunstall@gmail.com> * formatting * add link to papers --------- Co-authored-by: lewtun <lewis.c.tunstall@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, we wanted to make small amendments to the release process, so that we have a 0.N.0 commit on main. I also adjusted the wording here and there.
There were some open questions, which I have marked with a
FIXME. Please let me know how to proceed with those.Note: For me, the GitHub diff view is not correct, so please check the changes carefully.