FIX: Failing AdaLoRA GPU test #2349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR huggingface#2341 added more rigorous checks for AdaLoRA and adjusted the tests to take that into account. However, one GPU test was missed. This test is now updated too, fixing the failing nightly CI (I ran it locally on GPU to verify). On top of that, I adjusted some numbers on the tests so that each AdaLoRA phase runs for 2 steps, leading to 6 steps total. This means that tests run a little bit longer but I think it's acceptable for better test coverage.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
githubnemo
approved these changes
Jan 27, 2025
Collaborator
githubnemo
left a comment
There was a problem hiding this comment.
Ah thanks for catching that. Good idea testing init and final steps as well. LGTM
Guy-Bilitski
pushed a commit
to Guy-Bilitski/peft
that referenced
this pull request
May 13, 2025
PR huggingface#2341 added more rigorous checks for AdaLoRA and adjusted the tests to take that into account. However, one GPU test was missed. This test is now updated too, fixing the failing nightly CI (I ran it locally on GPU to verify). On top of that, I adjusted some numbers on the tests so that each AdaLoRA phase runs for 2 steps, leading to 6 steps total. This means that tests run a little bit longer but I think it's acceptable for better test coverage.
cyyever
pushed a commit
to cyyever/peft
that referenced
this pull request
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2341 added more rigorous checks for AdaLoRA and adjusted the tests to take that into account. However, one GPU test was missed. This test is now updated too, fixing the failing nightly CI (I ran it locally on GPU to verify).
On top of that, I adjusted some numbers on the tests so that each AdaLoRA phase runs for 2 steps, leading to 6 steps total. This means that tests run a little bit longer but I think it's acceptable for better test coverage.