Use locked install for zizmor #2350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be on the safe side when installing zizmor and it's dependencies we're using a locked installation, meaning that the dependencies and their versions are taken from the Cargo.lock file. This will hopefully reduce the chances of having the pipeline randomly fail due to updated dependencies down the line.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
BenjaminBossan
approved these changes
Jan 28, 2025
Member
BenjaminBossan
left a comment
There was a problem hiding this comment.
I think it makes sense in our context. Can be merged once CI is green.
Guy-Bilitski
pushed a commit
to Guy-Bilitski/peft
that referenced
this pull request
May 13, 2025
To be on the safe side when installing zizmor and it's dependencies we're using a locked installation, meaning that the dependencies and their versions are taken from the Cargo.lock file. This will hopefully reduce the chances of having the pipeline randomly fail due to updated dependencies down the line.
cyyever
pushed a commit
to cyyever/peft
that referenced
this pull request
Sep 4, 2025
huggingface#2350) * Add guidelines for working with warnings in the codebase * Remove unnecessary warnings and improve code initialization * Fix warnings and improve accuracy calculation * Add rich library dependency for text formatting * Update LoRA weight loading warning message * Fix logging and import issues in AlignPropConfig * Fix warnings and improve code readability * Remove unused import statements * Refactor CPOTrainer class in cpo_trainer.py * Remove unnecessary warnings and raise ValueError for missing model * Fix warnings and improve code consistency * Update CONTRIBUTING.md to clarify the purpose of warnings * Fix string formatting in DataCollatorForCompletionOnlyLM class * Update SimPO loss parameters in CPOTrainer * Fix warnings and remove unnecessary code in ConstantLengthDataset class * Clarify warning guidelines * Rewrite the entire section * Fix capitalization in CONTRIBUTING.md * Fix formatting in CONTRIBUTING.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be on the safe side when installing zizmor and it's dependencies we're using a locked installation, meaning that the dependencies and their versions are taken from the Cargo.lock file.
This will hopefully reduce the chances of having the pipeline randomly fail due to updated dependencies down the line.