Skip to content

TST make 3 flaky test cases always pass on XPU #2503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BenjaminBossan merged 1 commit into from
Apr 23, 2025
Merged

TST make 3 flaky test cases always pass on XPU #2503

BenjaminBossan merged 1 commit into from
Apr 23, 2025

Conversation

@yao-matrix
Copy link
Contributor

@yao-matrix yao-matrix commented Apr 18, 2025

PASSED tests/test_initialization.py::TestAdaLoraInitialization::test_adalora_default_init_identity
PASSED tests/test_initialization.py::TestLokrInitialization::test_lokr_linear_init_default
PASSED tests/test_gpu_examples.py::TestPTuningReproducibility::test_p_tuning_exactly_reproducible_after_loading

@yao-matrix
make 3 flaky test cases always pass on XPU
1c8b21b 
Signed-off-by: YAO Matrix <matrix.yao@intel.com>
@yao-matrix
Copy link
Contributor Author

yao-matrix commented Apr 18, 2025

@BenjaminBossan, pls help review, thx.

@BenjaminBossan
Copy link
Member

BenjaminBossan commented Apr 22, 2025

This means that require_deterministic_for_xpu can be removed completely, right?

@yao-matrix
Copy link
Contributor Author

yao-matrix commented Apr 22, 2025

This means that require_deterministic_for_xpu can be removed completely, right?

@BenjaminBossan seems no, actually I added 3 more cases which require_deterministic_for_xpu in this PR, so we still it now. Good news is seems we've found the operator leads to such numerical differences, but we still need time to see how to fix and validate, op numerical things are usually pretty complex. Once they are fixed and validated, i will submit PRs and remove require_deterministic_for_xpu if needed.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 23, 2025

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

BenjaminBossan
BenjaminBossan approved these changes Apr 23, 2025
View reviewed changes
Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM.

@BenjaminBossan BenjaminBossan merged commit 2e39c89 into huggingface:main Apr 23, 2025
14 checks passed
@yao-matrix yao-matrix deleted the issue51 branch April 23, 2025 22:42
Guy-Bilitski pushed a commit to Guy-Bilitski/peft that referenced this pull request May 13, 2025
@yao-matrix
TST Make 3 flaky tests pass on XPU (huggingface#2503)
84f8087 
Signed-off-by: YAO Matrix <matrix.yao@intel.com>
efraimdahl pushed a commit to efraimdahl/peft that referenced this pull request Jul 12, 2025
@yao-matrix @efraimdahl
TST Make 3 flaky tests pass on XPU (huggingface#2503)
3705a8e 
Signed-off-by: YAO Matrix <matrix.yao@intel.com>
cyyever pushed a commit to cyyever/peft that referenced this pull request Sep 4, 2025
@qgallouedec
📦 Packing documentation (huggingface#2503)
aed5da5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenjaminBossan BenjaminBossan BenjaminBossan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yao-matrix @BenjaminBossan @HuggingFaceDocBuilderDev