FIX: Use correct argument name in MultiheadAttention forward #2510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The arguments of the forward method of MultiheadAttention are called query etc. PEFT used x. Therefore, if a caller uses keywords only, the argument is not assigned, resulting in an error. This was initially reported here: huggingface#761 (comment) Note: Other layers' forward method (like Linear) also uses incorrect names, like x instead of input, but so far no issues were reported, so I'll leave it as is for now.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
githubnemo
approved these changes
May 5, 2025
efraimdahl
pushed a commit
to efraimdahl/peft
that referenced
this pull request
Jul 12, 2025
The arguments of the forward method of MultiheadAttention are called query etc. PEFT used x. Therefore, if a caller uses keywords only, the argument is not assigned, resulting in an error. This was initially reported here: huggingface#761 (comment) Note: Other layers' forward method (like Linear) also uses incorrect names, like x instead of input, but so far no issues were reported, so I'll leave it as is for now.
cyyever
pushed a commit
to cyyever/peft
that referenced
this pull request
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arguments of the
forwardmethod ofMultiheadAttentionare calledqueryetc. PEFT usedx. Therefore, if a caller uses keywords only, the argument is not assigned, resulting in an error.This was initially reported here:
#761 (comment)
Note: Other layers'
forwardmethod (likeLinear) also uses incorrect names, likexinstead ofinput, but so far no issues were reported, so I'll leave it as is for now.