FIX: Faulty OFT parameter device test #2630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an error in an OFT test because .cpu() is called on a parameter instead of a module. Calling it on parameter is not an in-place operation, so it has no effect.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
@BenjaminBossan Thanks, can you point me to the test? |
Member
Author
Line 1882 in 45996a1 |
zqiu24
approved these changes
Jul 5, 2025
githubnemo
approved these changes
Jul 7, 2025
efraimdahl
pushed a commit
to efraimdahl/peft
that referenced
this pull request
Jul 12, 2025
There is an error in an OFT test because .cpu() is called on a parameter instead of a module. Calling it on parameter is not an in-place operation, so it has no effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an error in an OFT test because
.cpu()is called on a parameter instead of a module. Calling it on parameter is not an in-place operation, so it has no effect.FYI @zqiu24