Skip to content

Proposing to remove SSDTrainer #7596

Description

@qgallouedec

Proposing to remove trl.experimental.ssd (SSDTrainer, SSDConfig), added in #5505 (2026-04-14), directly into trl.experimental. Reporting the inputs discussed in #7182.

Usage.

External issues and pull requests.

  • None from outside the maintainer team in the 6 months since it landed.

Subsumed.

  • Yes. The paper's recipe is two steps: sample from the model at a training-time temperature and truncation, then standard SFT on the samples. Generating with vLLM and training with SFTTrainer covers it. What goes away is the sampling inside the training loop.

Cost.

Downstream consumers.

  • None. GitHub code search finds three zero-star personal repos referencing it, everything else is vendored copies of the trl tree and docs mirrors.

Owner.

  • @kashif landed it, no feature work since.

Age.

  • 6 months in trl.experimental, shipped in every release from v1.2.0 to v1.15.0 with only upkeep commits since it landed. Long enough to have been found.

This issue aims to collect feedback from the community, if any. If none:

  • remove the module, test, doc page and examples/ssd_codegen/, and
  • keep the paper index entry pointing to the last release that shipped it.

Activity

  1. Talhax55z commented on Oct 9, 2026

    @Talhax55z

    starting on this one !

  2. Talhax55z commented on Oct 9, 2026

    @Talhax55z

    @qgallouedec Happy to open the removal PR if there are no objections, could you assign me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions