Renaming of internal variables: async_reward_X to async_X#5616
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e7ad7c7. Configure here.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces a bit the number of line diff between grpo and rloo, and is harmless
Note
Low Risk
Low risk rename-only refactor of internal async reward-loop attributes and helper coroutine names, with no logic changes to reward computation.
Overview
Renames
RLOOTrainer’s internal async reward-loop fields fromasync_reward_*to shorterasync_*(e.g.,_has_async_funcs,async_loop,async_loop_thread,async_loop_ready_event) and updates the async invocation helper used byasyncio.gatheraccordingly.No functional changes are introduced; this is a consistency/maintenance refactor around async reward execution and shutdown registration.
Reviewed by Cursor Bugbot for commit caec6bf. Bugbot is set up for automated code reviews on this repo. Configure here.