Remove redundant is_peft_available from core trainers#5682
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7f89777. Configure here.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove redundant
is_peft_availablefrom core trainers.This PR simplifies the logic for checking PEFT (Parameter-Efficient Fine-Tuning) availability in several trainer classes. The main change is the removal of redundant
is_peft_available()checks, relying solely onis_peft_model(model)to determine if PEFT-specific logic should be applied. This results in cleaner and more maintainable code across multiple trainers.Trainer logic simplification:
is_peft_available()checks in favor of only usingis_peft_model(model)when determining if PEFT-related operations (such as adding adapters or enabling input gradients) should be performed inDPOTrainer,GRPOTrainer,RLOOTrainer,RewardTrainer, andSFTTrainer.Note
Low Risk
Small conditional-logic simplification around PEFT paths; behavior should be unchanged as long as
is_peft_model()remains the single source of truth for PEFT detection.Overview
Simplifies PEFT-specific control flow across
DPOTrainer,GRPOTrainer,RLOOTrainer,RewardTrainer, andSFTTrainerby removing redundantis_peft_available()guards and keying PEFT behavior solely offis_peft_model(model).This affects when trainers create a
refadapter for reference-policy comparisons and when they callenable_input_require_grads()under gradient checkpointing, without changing the underlying PEFT operations themselves.Reviewed by Cursor Bugbot for commit 381c312. Bugbot is set up for automated code reviews on this repo. Configure here.