Add backwards memory examination for the dereference command #942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grazfather
reviewed
Apr 4, 2023
gef.py
Outdated
| to_insnum = self.repeat_count * nb - 1 | ||
| insnum_step = -1 | ||
| else: | ||
| from_insnum = 0 + self.repeat_count * nb |
There was a problem hiding this comment.
The previous implementation had them, so I simply left them in place. I can't tell why they were placed, so I just left them there in case there's some obsure edge-case that I'm not aware of.
gef.py
Outdated
| if nb > 0: | ||
| from_insnum = nb * (self.repeat_count + 1) - 1 | ||
| to_insnum = self.repeat_count * nb - 1 | ||
| insnum_step = -1 |
There was a problem hiding this comment.
we don't have to repeat this line in both cases
gef.py
Outdated
| if nb > 0: | ||
| from_insnum = 0 + self.repeat_count * nb | ||
| to_insnum = nb * (self.repeat_count + 1) | ||
| insnum_step = 1 |
There was a problem hiding this comment.
we don't have to repeat this in both cases
gef.py
Outdated
| to_insnum = nb * (self.repeat_count + 1) | ||
| insnum_step = 1 | ||
| if nb > 0: | ||
| from_insnum = 0 + self.repeat_count * nb |
hugsy
requested changes
Apr 4, 2023
Grazfather
reviewed
Apr 4, 2023
tests/commands/dereference.py
Outdated
| ] | ||
| res = gdb_start_silent_cmd(cmd=setup, after=cmd) | ||
| self.assertNoException(res) | ||
| print(res) |
tests/commands/dereference.py
Outdated
| ] | ||
| res = gdb_start_silent_cmd(cmd=setup, after=cmd) | ||
| self.assertNoException(res) | ||
| print(res) |
gef.py
Outdated
| to_insnum = nb * (self.repeat_count + 1) | ||
| else: | ||
| from_insnum = nb * (self.repeat_count + 1) + 1 | ||
| to_insnum = (0 + self.repeat_count * nb) + 1 |
tests/commands/dereference.py
Outdated
| """ | ||
| res = res.splitlines()[-2] | ||
| self.assertTrue("AAAAAAAA" not in res) | ||
| self.assertTrue("BBBBBBBB" in res) |
tests/commands/dereference.py
Outdated
| Hence, we want to look at the second last line of the output | ||
| """ | ||
| res = res.splitlines()[-1] | ||
| self.assertTrue("AAAAAAAA" in res) |
tests/commands/dereference.py
Outdated
| """ | ||
| res = res.splitlines()[-1] | ||
| self.assertTrue("AAAAAAAA" in res) | ||
| self.assertTrue("BBBBBBBB" not in res) |
Grazfather
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description/Motivation/Screenshots
This commit extends the
dereferencecommand, allowing to examine memory backwards via a negative--lengthvalue, analogous to the behaviour ofx.Against which architecture was this tested ?
"Tested" indicates that the PR works and the unit test (see
docs/testing.md) run passes without issue.Checklist
devbranch, notmain.