feat/use gateway_api_host as CN and DNS in certs #7841
+27
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
This PR fixes #7399
client_cert will use 'hummingbot' as CN and DNS
server_cert will use 'localhost' as CN and DNS by default OR gateway_api_host attribute when configured.
ca_cert will use 'localhost' as O and CN by default OR gateway_api_host attribute when configured.
Tests performed by the developer:
./compile
./start
config gateway.gateway_api_host: some_host
gateway generate-certs
Check csr and certs with openssl cli.
Also tested with config gateway_api_host default value
Use certs with hummingbot and gateway, connection OK
Tips for QA testing: