feat/update controllers performance report #7884
Merged
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cardosofede
approved these changes
Dec 17, 2025
Contributor
cardosofede
left a comment
There was a problem hiding this comment.
just apply that typing check
| self.config = config | ||
| self.executors_info: List[ExecutorInfo] = [] | ||
| self.positions_held: List[PositionSummary] = [] | ||
| self.performance_report: PerformanceReport = None |
Contributor
There was a problem hiding this comment.
probably you need to type it as Optional[PerformanceReport]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
This PR is meant to push the performance report to controllers so the data is accessible from inside the controller itself.
The purpose is to use realized PnL for compound interest.
Tests performed by the developer:
./start
Run controller and print :
self.logger().info(f"Realized PnL quote: {self.performance_report.realized_pnl_quote}")Tips for QA testing: