Draft Link/Button Ref#7905
Draft
luke- wants to merge 4 commits into
Draft
Conversation
marc-farre
requested changes
Dec 14, 2025
| } | ||
|
|
||
| $optionsRef = $this->getOptionsRef(); | ||
| $optionsRef = ArrayHelper::merge($this->getOptionsRef(), $options); |
Collaborator
There was a problem hiding this comment.
Looks weird in the IDE:
| /** | ||
| * @param string $color Hexadecimal, RGB, RGBA, HSL, HSLA | ||
| */ | ||
| public function cssBgColor(?string $color): static |
Collaborator
There was a problem hiding this comment.
I think we shouldn't encourage adding inline styling, especially for colors.
We already have ->style() for the rare case when we really need to force a color.
Instead, I would create a cssColor() method for the HtmlA class, which would only accept a BS color (success, etc.)
It would add one of these classes: https://getbootstrap.com/docs/5.3/helpers/colored-links/#link-colors
| /** | ||
| * @param string $color Hexadecimal, RGB, RGBA, HSL, HSLA | ||
| */ | ||
| public function cssTextColor(?string $color): static |
Collaborator
There was a problem hiding this comment.
Same here, I would remove it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
developbranch, not themasterbranch if no hotfixFix #xxx[,#xxx], where "xxx" is the Github issue number)If adding a new feature, the PR's description includes:
Other information: