bug fix - when the first section has a background-video, the vido do … #1376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not execute. Now, it's work
|
Thanks for your contribution. Some part of your PR (spacing, indents…) do not match the overall coding style of reveal. Could you please fix these details please? Thanks. |
Contributor
Author
|
Hi Delapouite, i updated the code. I removed the extras lines, but i think that indentation is right, no? If no, how many spaces the reveal.js adopt? Appears adjusted on my machine. Thanks! |
…ty from video element
Conflicts: js/reveal.js
…ate property from video element
Owner
|
Thanks for the fix! Your commit has been merged into the dev branch, in the future please submit all pull requests directly towards the dev branch. I made a few minor tweaks in 3d33d27 |
SteveDesmond-ca
pushed a commit
to SteveDesmond-ca/presentations
that referenced
this pull request
Apr 19, 2017
This was referenced Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
correction based on the issue:
Background video does not play on the first slide loaded #1314