Update Electron & iohook, Remove unused dev dependencies and Major improvements to debugging #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on changes the logging level
hainguyents13
approved these changes
Feb 16, 2024
NotLazy
added a commit
to NotLazy/mechvibes
that referenced
this pull request
Feb 17, 2024
…provements to debugging (hainguyents13#292) * improve renderer logging to allow leveling logs instead of defaulting to info * update css * Extend logging * fix console transport, so it doesn't affect other transports. * Add alert for when debugging is enabled * Hide FAQ for now, as the link doesn't work, and we don't have on-site FAQ yet. * add debug window * change url * prototype enable/disable function * modify remote transport * remove unused dependencies * Update Electron * polyfill fetch() plus add util for it * Update shell.openItem because its deprecated * update lock files * Simple Remote Debugging release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title, plus move iohook to main process because of electron update, hide FAQ because the website doesn't have it, and major changes to remote debugging.
I've added a "Advanced" window, which can be used to toggle on/off remote debugging, which displays a code that can be shared with those who have access to remote debug ("Debuggers"). I've also overwritten the remote transport from electron-log, in order to improve it, and to allow further improvement in the future, including making it log to the file when remote logging is occuring, and making it respond to HTTP response codes.
There's also an alert in the main window when remote debugging is enabled.
I've also improved the logging from the app to the main process to include levels.