Skip to content

Refactor user batch enable/disable logic and update i18n #7647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ruibaby merged 2 commits into from
Jul 31, 2025
Merged

Refactor user batch enable/disable logic and update i18n #7647

ruibaby merged 2 commits into from
Jul 31, 2025

Conversation

@ruibaby
Copy link
Member

@ruibaby ruibaby commented Jul 31, 2025

What type of PR is this?

/kind improvement
/area ui
/milestone 2.21.x

What this PR does / why we need it:

  1. Refactor user batch enable/disable logic
  2. Update i18n

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. labels Jul 31, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.21.x milestone Jul 31, 2025
@f2c-ci-robot f2c-ci-robot bot added the area/ui Issues or PRs related to the Halo UI label Jul 31, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wan92hen July 31, 2025 03:32
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jul 31, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ruibaby for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jul 31, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.66%. Comparing base (42c374d) to head (45b7298).
⚠️ Report is 113 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #7647      +/-   ##
============================================
+ Coverage     59.55%   59.66%   +0.10%     
+ Complexity     3812     3790      -22     
============================================
  Files           677      676       -1     
  Lines         23248    23112     -136     
  Branches       1500     1483      -17     
============================================
- Hits          13846    13789      -57     
+ Misses         8764     8688      -76     
+ Partials        638      635       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 31, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ruibaby ruibaby merged commit 87cb00a into halo-dev:main Jul 31, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnNiang JohnNiang Awaiting requested review from JohnNiang

@wan92hen wan92hen Awaiting requested review from wan92hen

Assignees

No one assigned

Labels

area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

2.21.x

Development

Successfully merging this pull request may close these issues.

1 participant

@ruibaby