Skip to content

Refactor image attachment thumbnail feature #7779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ruibaby merged 2 commits into from
Oct 2, 2025
Merged

Refactor image attachment thumbnail feature #7779

ruibaby merged 2 commits into from
Oct 2, 2025

Conversation

@JohnNiang
Copy link
Member

@JohnNiang JohnNiang commented Sep 23, 2025 •
edited by ruibaby
Loading

What type of PR is this?

/kind improvement
/kind api-change
/area core
/milestone 2.21.x

What this PR does / why we need it:

This PR adds a new router for generating thumbnail at runtime, e.g.: http://localhost:8090/upload/path/to/halo.png?width=400.

Which issue(s) this PR fixes:

Fixes #7771
Fixes #7757
Fixes #7764
Fixes #7758
Fixes #7625
Fixes #7497
Fixes #7110
Fixes #7015
Fixes #6697

Special notes for your reviewer:

Does this PR introduce a user-facing change?

重构图片缩略图功能，移除缩略图记录，改为按需生成

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 23, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.21.x milestone Sep 23, 2025
@f2c-ci-robot f2c-ci-robot bot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API area/core Issues or PRs related to the Halo Core labels Sep 23, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and ruibaby September 23, 2025 09:10
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign johnniang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JohnNiang JohnNiang modified the milestones: 2.21.x, 2.22.x Sep 23, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 29, 2025 •
edited
Loading

Open in StackBlitz

@halo-dev/api-client

npm i https://pkg.pr.new/@halo-dev/api-client@7779

@halo-dev/components

npm i https://pkg.pr.new/@halo-dev/components@7779

@halo-dev/richtext-editor

npm i https://pkg.pr.new/@halo-dev/richtext-editor@7779

@halo-dev/console-shared

npm i https://pkg.pr.new/@halo-dev/console-shared@7779

@halo-dev/ui-plugin-bundler-kit

npm i https://pkg.pr.new/@halo-dev/ui-plugin-bundler-kit@7779

commit: 5e6de80

@JohnNiang JohnNiang mentioned this pull request Sep 30, 2025
Closed
4 tasks
@ruibaby ruibaby changed the title WIP: Add thumbnail generation router for image uploads Refactor image attachment thumbnail feature Oct 1, 2025
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 1, 2025
@ruibaby ruibaby force-pushed the feat/add-thumbnail-router branch from b469d4f to 5e6de80 Compare October 2, 2025 02:31
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2025

Quality Gate Passed Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ruibaby ruibaby merged commit 2f561d4 into main Oct 2, 2025
11 of 12 checks passed
@JohnNiang JohnNiang deleted the feat/add-thumbnail-router branch October 2, 2025 03:12
@JohnNiang JohnNiang modified the milestones: 2.22.x, 2.22.0 Oct 10, 2025
This was referenced Oct 12, 2025
Closed
Closed
Merged
@ruibaby ruibaby mentioned this pull request Oct 24, 2025
Closed
@JohnNiang JohnNiang mentioned this pull request Dec 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LIlGG LIlGG Awaiting requested review from LIlGG

@ruibaby ruibaby Awaiting requested review from ruibaby

Assignees

No one assigned

Labels

area/core Issues or PRs related to the Halo Core kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

2.22.0

3 participants

@JohnNiang @ruibaby