Skip to content

Fix missing add button in secret list modal #8073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ruibaby merged 1 commit into from
Dec 23, 2025
Merged

Fix missing add button in secret list modal #8073

ruibaby merged 1 commit into from
Dec 23, 2025
+4 −0

Conversation

@ruibaby
Copy link
Member

@ruibaby ruibaby commented Dec 22, 2025

What type of PR is this?

/area ui
/kind bug
/milestone 2.22.x

What this PR does / why we need it:

Fix missing add button in secret list modal

Does this PR introduce a user-facing change?

修复密钥列表界面不显示添加按钮的问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ui Issues or PRs related to the Halo UI labels Dec 22, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.22.x milestone Dec 22, 2025
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 22, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 22, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign guqing for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Dec 22, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.77%. Comparing base (42c374d) to head (dcfe36b).
⚠️ Report is 339 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #8073      +/-   ##
============================================
+ Coverage     59.55%   60.77%   +1.21%     
- Complexity     3812     3947     +135     
============================================
  Files           677      692      +15     
  Lines         23248    23527     +279     
  Branches       1500     1525      +25     
============================================
+ Hits          13846    14298     +452     
+ Misses         8764     8503     -261     
- Partials        638      726      +88

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

guqing
guqing reviewed Dec 23, 2025
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2025
@ruibaby ruibaby merged commit e27d91a into halo-dev:main Dec 23, 2025
9 of 10 checks passed
@ruibaby ruibaby deleted the fix/secret-modal branch December 23, 2025 09:07
@JohnNiang JohnNiang modified the milestones: 2.22.x, 2.22.0 Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guqing guqing guqing left review comments

Assignees

@guqing guqing

Labels

area/ui Issues or PRs related to the Halo UI kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

2.22.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ruibaby @guqing @JohnNiang