fix: array component does not support multiple image selection#8360
Merged
Conversation
Allow renderer functions to return either a single LabelValueResult or an array of them and handle those arrays when formatting item labels. Adds a new attachment renderer and registers it. Update types (LabelValueRenderer) and renderItemLabelValue signature to accept array results, update ArrayInput parsing to normalize/flatten renderer outputs (use toArray) and map array responses into FormattedItemLabel entries. Files changed: ArrayInput.vue (handle array renderer results, import toArray), renderers/index.ts (register attachment renderer, update import/exports), renderers/types.ts (broaden renderer return types), renderers/attachment.ts (new attachment renderer).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8360 +/- ##
============================================
+ Coverage 59.55% 60.83% +1.27%
- Complexity 3812 3999 +187
============================================
Files 677 698 +21
Lines 23248 23856 +608
Branches 1500 1555 +55
============================================
+ Hits 13846 14513 +667
+ Misses 8764 8613 -151
- Partials 638 730 +92 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/area ui
What this PR does / why we need it:
解决 array 组件无法处理
attachement之类可多选的图片组件的渲染。Which issue(s) this PR fixes:
Fixes #8354
Does this PR introduce a user-facing change?