fix: filter out tab slots missing id or label#8361
Merged
Conversation
When building tabItems from default slots, filter out any slot entries whose id or label are undefined. This prevents undefined tab entries from being included in the tabs list and makes the component more robust against incomplete slot props.
|
@halo-dev/api-client
@halo-dev/components
@halo-dev/richtext-editor
@halo-dev/ui-shared
@halo-dev/ui-plugin-bundler-kit
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8361 +/- ##
============================================
+ Coverage 59.55% 60.83% +1.27%
- Complexity 3812 3998 +186
============================================
Files 677 698 +21
Lines 23248 23856 +608
Branches 1500 1555 +55
============================================
+ Hits 13846 14512 +666
+ Misses 8764 8613 -151
- Partials 638 731 +93 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/area ui
What this PR does / why we need it:
由于当注释掉或者使用判断语句隐藏掉的 slot 仍旧会出现在 useSlots() 中，因此选择过滤掉 slots 中为
undefinedslot。Which issue(s) this PR fixes:
Fixes #8349
Does this PR introduce a user-facing change?