Fix "Finder with name 'xxx' is already registered" on plugin re-registration by Copilot · Pull Request #9853 · halo-dev/halo

Copilot · 2026-04-07T08:45:01Z

What type of PR is this?

/kind bug

What this PR does / why we need it:

When a plugin's Spring context fires ContextRefreshedEvent (registering finders) but is then abandoned without a corresponding ContextClosedEvent — e.g., when finishRefresh() throws after the event, or when cleanup fails — the finder entries remain stale in DefaultFinderRegistry. The next start attempt (e.g., after a plugin upgrade) throws "Finder with name 'xxxFinder' is already registered", requiring a Halo restart to recover.

Fix: Call unregister(pluginId) at the top of register() to evict any stale entries for that plugin before registering new ones. This makes registration idempotent per plugin while still detecting genuine name conflicts across different plugins.

// DefaultFinderRegistry.register()
public void register(String pluginId, ApplicationContext pluginContext) {
    unregister(pluginId); // evict stale state before re-registering
    pluginContext.getBeansWithAnnotation(Finder.class)
        .forEach((beanName, finder) -> { ... });
}

Which issue(s) this PR fixes:

Fixes #9798

Special notes for your reviewer:

unregister() on an unknown pluginId is a no-op (map miss), so this adds zero overhead on normal first-time registration.

Does this PR introduce a user-facing change?

修复部分包含 Finder API 的插件可能在升级后无法正常启动的问题

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

checkstyle.org
- Triggering command: /opt/hostedtoolcache/CodeQL/2.25.1/x64/codeql/tools/linux64/java/bin/java /opt/hostedtoolcache/CodeQL/2.25.1/x64/codeql/tools/linux64/java/bin/java -jar /opt/hostedtoolcache/CodeQL/2.25.1/x64/codeql/xml/tools/xml-extractor.jar --fileList=/tmp/codeql-scratch-dd1d0a2b113c8104/dbs/java/working/files-to-index5977883620544843849.list --sourceArchiveDir=/tmp/codeql-scratch-dd1d0a2b113c8104/dbs/java/src --outputDir=/tmp/codeql-scratch-dd1d0a2b113c8104/dbs/java/trap/java (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

CLAassistant · 2026-04-07T08:45:11Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

…isters finders When a plugin's Spring context partially registers finders then fails (leaving stale entries), subsequent start attempts throw "already registered". Fix by calling unregister(pluginId) at the start of register() to clean up stale state. Also adds tests for register/unregister plugin finders and the re-registration scenario. Agent-Logs-Url: https://github.com/halo-dev/halo/sessions/f07880fa-01f5-40a5-93cf-fc041187c3ed Co-authored-by: ruibaby <21301288+ruibaby@users.noreply.github.com>

sonarqubecloud · 2026-04-07T09:31:17Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ruibaby · 2026-04-07T09:59:23Z

/cherry-pick release-2.23

halo-dev-bot · 2026-04-07T09:59:28Z

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.23 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-2.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ruibaby

/lgtm

f2c-ci-robot · 2026-04-07T10:13:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [ruibaby]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

halo-dev-bot · 2026-04-07T10:44:31Z

@ruibaby: #9853 failed to apply on top of branch "release-2.23":

Patch is empty.
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To record the empty patch as an empty commit, run "git am --allow-empty".
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"

Details

In response to this:

/cherry-pick release-2.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ruibaby · 2026-04-07T10:45:26Z

/cherry-pick release-2.23

halo-dev-bot · 2026-04-07T10:46:04Z

@ruibaby: #9853 failed to apply on top of branch "release-2.23":

Patch is empty.
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To record the empty patch as an empty commit, run "git am --allow-empty".
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"

Details

In response to this:

/cherry-pick release-2.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ruibaby · 2026-04-09T09:39:13Z

/cherry-pick release-2.23

halo-dev-bot · 2026-04-09T09:39:53Z

@ruibaby: #9853 failed to apply on top of branch "release-2.23":

Patch is empty.
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To record the empty patch as an empty commit, run "git am --allow-empty".
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"

Details

In response to this:

/cherry-pick release-2.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

…tration (halo-dev#9853) * Initial plan * Fix "Finder with name 'xxx' is already registered" when plugin re-registers finders When a plugin's Spring context partially registers finders then fails (leaving stale entries), subsequent start attempts throw "already registered". Fix by calling unregister(pluginId) at the start of register() to clean up stale state. Also adds tests for register/unregister plugin finders and the re-registration scenario. Agent-Logs-Url: https://github.com/halo-dev/halo/sessions/f07880fa-01f5-40a5-93cf-fc041187c3ed Co-authored-by: ruibaby <21301288+ruibaby@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ruibaby <21301288+ruibaby@users.noreply.github.com>

…tration (#9853) (#9876) * Initial plan * Fix "Finder with name 'xxx' is already registered" when plugin re-registers finders When a plugin's Spring context partially registers finders then fails (leaving stale entries), subsequent start attempts throw "already registered". Fix by calling unregister(pluginId) at the start of register() to clean up stale state. Also adds tests for register/unregister plugin finders and the re-registration scenario. Agent-Logs-Url: https://github.com/halo-dev/halo/sessions/f07880fa-01f5-40a5-93cf-fc041187c3ed --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: ruibaby <21301288+ruibaby@users.noreply.github.com>

Initial plan

1b1a569

Copilot AI assigned Copilot and ruibaby Apr 7, 2026

f2c-ci-robot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2026

Copilot started work on behalf of ruibaby April 7, 2026 08:45 View session

Copilot AI linked an issue Apr 7, 2026 that may be closed by this pull request

Finder with name 'xxxFinder' is already registered #9798

Closed

4 tasks

f2c-ci-robot Bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Apr 7, 2026

Copilot AI changed the title ~~[WIP] Fix finder with name 'xxxFinder' is already registered~~ Fix "Finder with name 'xxx' is already registered" on plugin re-registration Apr 7, 2026

f2c-ci-robot Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 7, 2026

Copilot finished work on behalf of ruibaby April 7, 2026 09:33

Copilot AI requested a review from ruibaby April 7, 2026 09:33

ruibaby marked this pull request as ready for review April 7, 2026 09:43

f2c-ci-robot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2026

ruibaby requested a review from JohnNiang April 7, 2026 09:59

ruibaby added this to the 2.24.x milestone Apr 7, 2026

ruibaby approved these changes Apr 7, 2026

View reviewed changes

f2c-ci-robot Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2026

f2c-ci-robot Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2026

ruibaby merged commit d2b23fb into main Apr 7, 2026
14 of 17 checks passed

ruibaby deleted the copilot/fix-finder-already-registered branch April 7, 2026 10:43

ruibaby mentioned this pull request Apr 13, 2026

[release-2.23] Fix "Finder with name 'xxx' is already registered" on plugin re-registration (#9853) #9876

Merged

ruibaby modified the milestones: 2.24.x, 2.24.0 Apr 16, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix "Finder with name 'xxx' is already registered" on plugin re-registration#9853

Fix "Finder with name 'xxx' is already registered" on plugin re-registration#9853
ruibaby merged 2 commits into
mainfrom
copilot/fix-finder-already-registered

Copilot AI commented Apr 7, 2026 •

edited by ruibaby

Loading

Uh oh!

CLAassistant commented Apr 7, 2026

Uh oh!

sonarqubecloud Bot commented Apr 7, 2026

Uh oh!

ruibaby commented Apr 7, 2026

Uh oh!

halo-dev-bot commented Apr 7, 2026

Uh oh!

ruibaby left a comment

Uh oh!

f2c-ci-robot Bot commented Apr 7, 2026

Uh oh!

Uh oh!

halo-dev-bot commented Apr 7, 2026

Uh oh!

ruibaby commented Apr 7, 2026

Uh oh!

halo-dev-bot commented Apr 7, 2026

Uh oh!

ruibaby commented Apr 9, 2026

Uh oh!

halo-dev-bot commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Copilot AI commented Apr 7, 2026 • edited by ruibaby Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

CLAassistant commented Apr 7, 2026

Uh oh!

sonarqubecloud Bot commented Apr 7, 2026

Quality Gate passed

Uh oh!

ruibaby commented Apr 7, 2026

Uh oh!

halo-dev-bot commented Apr 7, 2026

Uh oh!

ruibaby left a comment

Choose a reason for hiding this comment

Uh oh!

f2c-ci-robot Bot commented Apr 7, 2026

Uh oh!

Uh oh!

halo-dev-bot commented Apr 7, 2026

Uh oh!

ruibaby commented Apr 7, 2026

Uh oh!

halo-dev-bot commented Apr 7, 2026

Uh oh!

ruibaby commented Apr 9, 2026

Uh oh!

halo-dev-bot commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Apr 7, 2026 •

edited by ruibaby

Loading