Skip to content

Refactor login parameter caching to use a generalized request cache#9893

Merged
f2c-ci-robot[bot] merged 1 commit into
mainfrom
refactor/support-retain-some-fields-after-login-failure
Apr 15, 2026
Merged

Refactor login parameter caching to use a generalized request cache#9893
f2c-ci-robot[bot] merged 1 commit into
mainfrom
refactor/support-retain-some-fields-after-login-failure

Conversation

@JohnNiang

Copy link
Copy Markdown
Member

What type of PR is this?

/kind improvement
/kind cleanup
/area core
/milestone 2.24.x

What this PR does / why we need it:

This PR refactors login parameter caching to use a generalized request cache.

Which issue(s) this PR fixes:

Fixes #6758

Special notes for your reviewer:

  1. Try to login with invalid credential with remember-me selected
  2. See the username input and remember-me checkbox
  3. Try to login with TOTP with remember-me selected
  4. See the cookies after logging in successfully

Does this PR introduce a user-facing change?

支持登录失败后回显用户名

@f2c-ci-robot f2c-ci-robot Bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 15, 2026
@f2c-ci-robot f2c-ci-robot Bot added this to the 2.24.x milestone Apr 15, 2026
@f2c-ci-robot f2c-ci-robot Bot added kind/improvement Categorizes issue or PR as related to a improvement. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/core Issues or PRs related to the Halo Core labels Apr 15, 2026
@sonarqubecloud

Copy link
Copy Markdown

@ruibaby ruibaby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2026
@f2c-ci-robot

f2c-ci-robot Bot commented Apr 15, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2026
@f2c-ci-robot f2c-ci-robot Bot merged commit b08b532 into main Apr 15, 2026
11 checks passed
@JohnNiang JohnNiang deleted the refactor/support-retain-some-fields-after-login-failure branch April 15, 2026 16:18
@ruibaby ruibaby modified the milestones: 2.24.x, 2.24.0 Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

期望登录表单在登录失败后回填用户名

2 participants