bounds inference (mod) pessimistic on unsigned 0 interval #5350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Only failure is unrelated LLVM breakage, good to land |
abadams
approved these changes
Oct 14, 2020
alexreinking
pushed a commit
that referenced
this pull request
Oct 16, 2020
* move conditions to catch unsigned interval >= 1 case first * use is_int_or_uint()
alexreinking
pushed a commit
that referenced
this pull request
Oct 18, 2020
* move conditions to catch unsigned interval >= 1 case first * use is_int_or_uint()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix discussed with @abadams and @alexreinking . Original code takes
b = [0u, 0u]and produces an interval of[0, b.type().max()]due to wrap-around. Technically correct but pessimistic/not tight. This fix removes that case and simplifies the overall generated expressioninterval.maxby removing themax()