Deprecate JIT runtime override methods that take void * #6344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steven-johnson
requested changes
Oct 25, 2021
Contributor
steven-johnson
left a comment
There was a problem hiding this comment.
LGTM except for comments
src/JITModule.h
Outdated
| /** A set of custom overrides of runtime functions */ | ||
| struct JITHandlers { | ||
| /** Set the function called to print messages from the runtime. | ||
| * If you are compiling statically, you can also just define your |
Contributor
There was a problem hiding this comment.
The comments about "if you are compiling statically" are arguably confusing and/or misplaced here. I'd suggest replacing everything after the first sentence with something like "(Note that this applies only when jitting code; if you are doing ahead-of-time compilation, see [README_foo.md or wherever we document this, rather than trying to replicate that documentation here])".
steven-johnson
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes care of the TODO from the previous PR exposing JITUserContext.
This deprecates things like set_custom_error in favor of just mutating the jit_handlers() struct