Remove halide_assert() from halide_default_device_wrap_native #6381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was inserted in #6310, probably mistakenly, since `halide_assert()` in the Halide runtime is *not* a debug-only assertion). Instead of a controlled runtime failure, we just abort, which is not OK.
vksnk
approved these changes
Nov 3, 2021
Contributor
Author
|
This may need to be backported to a Halide 13.x bugfix release, depending on whether #6310 was included in that release (@alexreinking) |
Member
We're in luck! #6310 did not make it in to Halide 13. 🙂 |
Contributor
Author
|
Failures should be fixed by #6386 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was inserted in #6310, probably mistakenly, since
halide_assert()in the Halide runtime is not a debug-only assertion). Instead of a controlled runtime failure, we just abort, which is not OK.