Skip to content

Conversation

@LebedevRI
Copy link
Contributor

I know we have previously discussed that TYPE DOC should be used,
but unfortunately i'm not sure that will work here,
because doc/tutorial directory is already occupied by C++ tutorials,
and i don't think they should be mixed.
I'm open to alternative suggestions.

I know we have previously discussed that `TYPE DOC` should be used,
but unfortunately i'm not sure that will work here,
because doc/tutorial directory is already occupied by C++ tutorials,
and i don't think they should be mixed.
I'm open to alternative suggestions.
Copy link
Member

@alexreinking alexreinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nitpick

@alexreinking
Copy link
Member

I know we have previously discussed that TYPE DOC should be used, but unfortunately i'm not sure that will work here,

Yeah, I think this is fine for now. We'd need to adjust our directory structure to be able to use TYPE DOC here, which... meh. It's low priority.

@alexreinking alexreinking added the backport me This change should be backported to release versions label Jan 4, 2022
@alexreinking alexreinking merged commit bce2ef4 into halide:master Jan 4, 2022
@LebedevRI LebedevRI deleted the install-python-tutorial branch January 4, 2022 21:06
@LebedevRI
Copy link
Contributor Author

@alexreinking thank you!

alexreinking pushed a commit that referenced this pull request Jan 5, 2022
* Install Python tutorials

I know we have previously discussed that `TYPE DOC` should be used,
but unfortunately i'm not sure that will work here,
because doc/tutorial directory is already occupied by C++ tutorials,
and i don't think they should be mixed.
I'm open to alternative suggestions.

(cherry picked from commit bce2ef4)
@alexreinking alexreinking removed the backport me This change should be backported to release versions label Jan 5, 2022
alexreinking pushed a commit that referenced this pull request Jan 6, 2022
* Install Python tutorials

I know we have previously discussed that `TYPE DOC` should be used,
but unfortunately i'm not sure that will work here,
because doc/tutorial directory is already occupied by C++ tutorials,
and i don't think they should be mixed.
I'm open to alternative suggestions.

(cherry picked from commit bce2ef4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants