Use n32:64 in RISC-V data layout #7175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM, please push one more commit to trigger the buildbots |
Member
|
Only question here is whether this should be conditional in the LLVM version. It looks like it was kind of always wrong. I guess the way to find out would be to make the change unconditional and see if if it still works with LLVM 15, but that may not be worth it. (The buildbots will not test that and I don't have an LLVM 15 tree handy.) Going to LGTM this. |
zvookin
approved these changes
Nov 28, 2022
Contributor
|
LGTM once buildbots are green. |
Contributor
Author
Contributor
|
Thanks for the fix! |
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
* Use n32:64 in RISC-V data layout * Remove unused LLVM header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: llvm/llvm-project@974e2e6
resolves #7174