Skip to content

Add hexagon_benchmarks app for CMake builds #8069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
steven-johnson merged 3 commits into from
Feb 7, 2024
Merged

Add hexagon_benchmarks app for CMake builds #8069

steven-johnson merged 3 commits into from
Feb 7, 2024

Conversation

@prasmish
Copy link
Contributor

@prasmish prasmish commented Feb 6, 2024 •
edited by alexreinking
Loading

This PR addresses the issue raised in #5374 regarding the lack of CMake support for hexagon_benchmark. Specifically, it introduces CMake build support for the hexagon_benchmark app which was previously missing.

During the process of adding this support, I observed that the sobel test was not building correctly with the target host-hvx. To keep this PR focused and manageable, the sobel test has been temporarily removed from this CMake script. A separate PR will be raised to rectify this issue and reintroduce the sobel test. (in #8127)

Fixes #8733

steven-johnson
steven-johnson approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@steven-johnson steven-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this fix! LGTM pending green.

@steven-johnson
Copy link
Contributor

steven-johnson commented Feb 6, 2024 

FAILED: hexagon_benchmarks/dilate3x3.generator 
: && /usr/bin/g++-9 -O3 -DNDEBUG -lc++abi hexagon_benchmarks/CMakeFiles/dilate3x3.generator.dir/dilate3x3_generator.cpp.o hexagon_benchmarks/CMakeFiles/dilate3x3.generator.dir/home/halidenightly/build_bot/worker/halide-testbranch-main-llvm17-x86-64-linux-cmake/halide-install/share/tools/GenGen.cpp.o -o hexagon_benchmarks/dilate3x3.generator  -Wl,-rpath,/home/halidenightly/build_bot/worker/halide-testbranch-main-llvm17-x86-64-linux-cmake/halide-install/lib  /home/halidenightly/build_bot/worker/halide-testbranch-main-llvm17-x86-64-linux-cmake/halide-install/lib/libHalide.so.18.0.0  -ldl && :
/usr/bin/ld: cannot find -lc++abi

@prasmish
Copy link
Contributor Author

prasmish commented Feb 7, 2024

Earlier, I was building Halide with Clang, which led to a minor issue here. I’ve now eliminated an unneeded flag (-lc++abi) and now it should build smoothly.

@steven-johnson
Copy link
Contributor

steven-johnson commented Feb 7, 2024

Failures are unrelated

@steven-johnson steven-johnson merged commit 78a0762 into halide:main Feb 7, 2024
@prasmish prasmish mentioned this pull request Feb 28, 2024
Merged
ardier pushed a commit to ardier/Halide-mutation that referenced this pull request Mar 3, 2024
@prasmish @ardier
Add hexagon_benchmarks app for CMake builds (halide#8069)
e63aeff 
* Add hexagon_benchmarks app for CMake builds

* Removed unnecessary -lc++abi flag from GCC build
@BrewTestBot BrewTestBot mentioned this pull request Jul 17, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steven-johnson steven-johnson steven-johnson approved these changes

@halidebuildbots halidebuildbots Awaiting requested review from halidebuildbots

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add testing for hexagon_benchmarks

2 participants

@prasmish @steven-johnson