[vulkan] Fixes to address outstanding validation failures #8448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 28, 2024 13:48
This resolves issues for CodeGen and runtime errors for bilateral_grid.
destruction calls for block allocator.
steven-johnson
approved these changes
Oct 29, 2024
Contributor
Author
|
Okay, this is good to go. I've been testing this on my local machine configs and this passes cleanly on Linux Ubuntu 22.04 w/Vulkan SDK v1.3.296 w/NVIDIA GeForce RTX 3070 TI. |
Contributor
Author
|
I'm also testing changes to avoid over-use of descriptor sets on resource constrained devices, but that'll be a larger PR. |
Member
|
Failure is unrelated flake |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8291
Fixes #8287
Fixes #8293