Limit depth more strictly in CSE fuzz test #8512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+25
to
+28
| auto p = pick_value_in_vector(fdp, exprs); | ||
| if (p.second <= depth) { | ||
| return p.first; | ||
| } |
Member
There was a problem hiding this comment.
How often do we expect this to fail?
Member
Author
There was a problem hiding this comment.
Rarely, in my testing. If an expression was generated earlier, it's probably simpler. But the fuzzing engine is good at finding corner cases.
steven-johnson
approved these changes
Dec 16, 2024
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should stop the jumbo recursive select exprs being generated. Hopefully fixes #8510 and #8504