Drop check for LLVM_LIBCXX in FindHalide_LLVM.cmake #8617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was never tested in CI, and grepping the LLVM sources (18 - main) for this variable comes up empty. Mixing standard libraries in a single project isn't a well-supported scenario anyway, so users wishing to override the standard library should use a consistent toolchain file between LLVM and Halide to do so.
steven-johnson
approved these changes
Apr 23, 2025
Member
Author
|
Failures are performance flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was never tested in CI, and grepping the LLVM sources (18 - main) for this variable comes up empty. Mixing standard libraries in a single project isn't a well-supported scenario anyway, so users wishing to override the standard library should use a consistent toolchain file between LLVM and Halide to do so.