Add (iOS) simulator target feature. #8623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steven-johnson
approved these changes
Apr 28, 2025
Member
|
Thanks, Alex! I will test this internally. |
Member
Author
|
@vksnk -- any updates? |
Member
|
Sorry for the delay, will test shortly. |
Contributor
|
I can verify that this worked. However, the Pipeline serialization feature does not seem to consider this new target feature. |
Contributor
|
This seems to fix some issues with building for simulator we encountered. @vksnk Have you had a chance to test? |
shoaibkamil
approved these changes
Sep 8, 2025
shoaibkamil
reviewed
Sep 8, 2025
Contributor
|
Merging it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt at adding simulator information to the LLVM triple via a target feature.
@vksnk - can you help me test this? AFAICT reading the LLVM sources, just setting the environment on the triple should be enough.
Fixes #8744