Add missing outputs to add_halide_library; fix advice in Lesson 21. #8660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extra outputs `conceptual_stmt`, `conceptual_stmt_html`, and `device_code` were missing. Cross-references between cmake/HalideGeneratorHelpers.cmake and src/Module.cpp were added in comments to serve as reminders to implement missing outputs.
abadams
approved these changes
Jun 24, 2025
Member
Author
|
Flaky performance tests. Unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extra outputs
conceptual_stmt,conceptual_stmt_html, anddevice_codewere missing. Cross-references betweencmake/HalideGeneratorHelpers.cmakeandsrc/Module.cppwere added in comments to serve as reminders to implement missing outputs.