Add an underlying type to the halide_buffer_flags to prevent UB in C++ #8690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix halide#8688). Co-authored-by: Alex Reinking <alex.reinking@gmail.com>
alexreinking
approved these changes
Jul 14, 2025
Contributor
Author
Contributor
Author
|
@alexreinking |
Member
|
Fuzz test failed: |
abadams
approved these changes
Aug 1, 2025
Member
abadams
left a comment
There was a problem hiding this comment.
I believe there are no ABI implications because the only thing this is ever passed to is always_inline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8688
Testing: https://godbolt.org/z/aPYK6K1vY