Skip to content
This repository was archived by the owner on Jan 18, 2026. It is now read-only.

fix: enum schema compatibility #557

Merged
nrwiersma merged 1 commit into from
Jul 29, 2025
Merged

fix: enum schema compatibility #557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion schema_compatibility.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,18 @@ func (c *SchemaCompatibility) checkEnumSymbols(reader, writer *EnumSchema) error
return nil
}

func (c *SchemaCompatibility) identicalEnumSymbols(reader, writer *EnumSchema) bool {
if len(reader.symbols) != len(writer.symbols) {
return false
}
for i := range len(reader.symbols) {
if reader.symbols[i] != writer.symbols[i] {
return false
}
}
return true
}

func (c *SchemaCompatibility) checkRecordFields(reader, writer *RecordSchema) error {
for _, field := range reader.Fields() {
f, ok := c.getField(writer.Fields(), field, func(gfo *getFieldOptions) {
Expand Down Expand Up @@ -348,9 +360,17 @@ func (c *SchemaCompatibility) resolve(reader, writer Schema) (schema Schema, res
enum.encodedSymbols = w.Symbols()
return enum, true, nil
}

return nil, false, err
}
if !c.identicalEnumSymbols(r, w) {
enum, _ := NewEnumSchema(r.Name(), r.Namespace(), r.Symbols(),
WithAliases(r.Aliases()),
WithDefault(r.Default()),
withWriterFingerprint(w.Fingerprint()),
)
enum.encodedSymbols = w.Symbols()
return enum, true, nil
}
return reader, false, nil
}

Expand Down
18 changes: 18 additions & 0 deletions schema_compatibility_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1017,3 +1017,21 @@ func TestSchemaCompatibility_ResolveWithFieldMissingInWriterAndReaderStruct(t *t

assert.Equal(t, want, result)
}

func TestSchemaCompatibility_ResolveWithEnums(t *testing.T) {
reader := avro.MustParse(`{"type": "enum", "name": "Enum", "symbols": ["A", "B", "C", "D"]}`)
writer := avro.MustParse(`{"type": "enum", "name": "Enum", "symbols": ["B", "C", "D"]}`)

data, err := avro.Marshal(writer, "D")
assert.NoError(t, err)

sc := avro.NewSchemaCompatibility()
rs, err := sc.Resolve(reader, writer)
assert.NoError(t, err)

var got string
err = avro.Unmarshal(rs, data, &got)
assert.NoError(t, err)

assert.Equal(t, "D", got)
}