Fix makeXCFramework.sh script #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated primary target to use SUPPORTED_PLATFORMS defined in XcodeTargets.xcconfig and not the project.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally introduced a bug in #97 as I changed the
archivecommands inmakeXCFramework.sh. Now the archive command follows the description from "Creating a multiplatform binary framework bundle" and leaves out the-sdkwhich is currently present.Additionally I also removed the usage of
SUPPORTED_PLATFORMSfrom the xcproj file as it should use the value defined in<PROJECT_ROOT>/Resources/XcodeTargets.xcconfig.