Skip to content

Conversation

@phcreery
Copy link
Contributor

@phcreery phcreery commented Dec 23, 2025

I wasn't able to test fs_createdate yet. Let me spend some more time and I will test it.

@hanatos
Copy link
Owner

hanatos commented Dec 23, 2025

awesome, thanks for looking into all these windows things. really hard for me to implement/test these.

there's at least one more windows thing in db.c, about timestamp offsets between different cameras: https://github.com/hanatos/vkdt/blob/master/src/db/db.c#L100

i have an exiftool metadata entry that displays the file's date, so i can verify the sort-by-date order in lighttable mode is good.

@phcreery
Copy link
Contributor Author

Oh thanks, didn't see that one. strptime doesn't seem to be provided by the ucrt64 lib... need to think some more on this one.

@phcreery
Copy link
Contributor Author

I found darktable's solution, https://github.com/darktable-org/darktable/blob/master/src/win/strptime.c

What is your opinion on pulling in a copy of strptime into vkdt?

@hanatos
Copy link
Owner

hanatos commented Dec 24, 2025

argh commenting github via email seems broken. trying to reproduce:

when importing dt code please clearly mark the portion as GPLv3, so people worried about licenses can remove it if they have to :)

other than that fine with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants